It's between snow/ice and shadow/dark/cursed for me. On the one hand I love the atmosphere in places like the Shadow Temple, Spirit Temple (which has one of the best soundtracks in the entire series), Arbiter's Grounds, Palace of Twilight and Earth Temple. On the other hand, ice temples have some absolutely brilliant (if frustrating at times) puzzles while not feeling like the endless chore that water temples feel like.