In my opinion, a game should never be announced/teased more than two years in advance, and should never be revealed with trailers and such any more than a year before. A year before release is ideal for announcement, six months is appropriate for full trailers.