My favorite controller due to the ergonomics and feel has to go to the Dualshock 4 Playstation controller.
A very close second is my special edition Xenoblade 2 Pro controller for Switch. The design is nice however my new favorite will be THIS one when it comes out.
I hope Amazon has discounts...